Admins country fix #1910
Merged
Admins country fix #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned first for the lookup.
kdiluca
previously approved these changes
Aug 22, 2019
There was a problem hiding this comment.
@dgearhart please see the comments and attachments in the #1903 issue
kdiluca
dismissed
their stale review
I think there's still an issue in Ireland...still testing.
|
@gknisely I believe we need to update the lua for Ireland as well as it's still showing driving_side as right. |
|
@gknisely @dgearhart I tested Ireland with latest admin.sqlite as well and we are good to go. |
|
Tests pass now in doc. Also, Malta does show correct driving_side as well: |
dgearhart
reviewed
Aug 23, 2019
| @@ -982,6 +983,14 @@ void BuildTileSet(const std::string& ways_file, | |||
|
|
|||
| graphtile.nodes().back().set_timezone(tz_index); | |||
|
|
|||
| // if you need to look at the attributes for nodes, grab the LL and update the if statement. | |||
dgearhart
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes drive on right vs drive on left issues.
Fixes #1903
Tasklist
Requirements / Relations