Enhanced fork assignment logic #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced ramp fork determination Collapse straight ramps
dgearhart
commented
Aug 23, 2019
| @@ -1243,6 +1243,21 @@ void ManeuversBuilder::SetManeuverType(Maneuver& maneuver, bool none_type_allowe | |||
| LOG_TRACE("ManeuverType=RAMP_STRAIGHT"); | |||
| break; | |||
| } | |||
| case Maneuver::RelativeDirection::KReverse: { | |||
There was a problem hiding this comment.
this was to compensate for bad data
dgearhart
commented
Aug 23, 2019
| @@ -1645,6 +1660,10 @@ bool ManeuversBuilder::CanManeuverIncludePrevEdge(Maneuver& maneuver, int node_i | |||
| return false; | |||
| } | |||
| if (maneuver.ramp() && prev_edge->IsRampUse()) { | |||
| // Do not combine if ramp to ramp is not forward | |||
There was a problem hiding this comment.
to make sure we call out a ramp-to-ramp turn
dgearhart
commented
Aug 23, 2019
|
|
||
| // If node is fork | ||
| // and prev to curr edge is relative straight | ||
| if (node->fork() && ((turn_degree > 315) || (turn_degree < 45))) { | ||
| // and the intersecting edge count is less than 3 |
There was a problem hiding this comment.
improved logic for fork determination - to remove the invalid forks
dgearhart
commented
Aug 23, 2019
| @@ -2195,7 +2220,8 @@ bool ManeuversBuilder::AreRampManeuversCombinable(std::list<Maneuver>::iterator | |||
| auto node = trip_path_->GetEnhancedNode(next_man->begin_node_index()); | |||
| if (!node->HasTraversableOutboundIntersectingEdge(next_man->travel_mode()) || | |||
| node->IsStraightestTraversableIntersectingEdgeReversed(curr_man->end_heading(), | |||
| next_man->travel_mode())) { | |||
| next_man->travel_mode()) || | |||
There was a problem hiding this comment.
collapse straight ramps
gknisely
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, there are instances where invalid fork instructions are produced or a ramp-to-ramp turn is missed.
Logic was added to do the following:
Improved 11% of the sample routes
Example
Tasklist