Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated private access logic. #1960

Merged
merged 4 commits into from
Oct 30, 2019
Merged

updated private access logic. #1960

merged 4 commits into from
Oct 30, 2019

Conversation

gknisely
Copy link
Member

@gknisely gknisely commented Oct 4, 2019

toss way where access=private and highway=service and service != driveway

Issue

Seeing issues where we are routing on roads where access is private. For example, service roads at airports. Logic tosses them if access=private and highway=service and service != driveway.

Before

image

After

image

Tasklist

  • Review - you must request approval to merge any PR to master
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

dgearhart
dgearhart previously approved these changes Oct 4, 2019
Copy link
Member

@dgearhart dgearhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

kevinkreiser
kevinkreiser previously approved these changes Oct 15, 2019
@dgearhart dgearhart added the WIP label Oct 15, 2019
@gknisely
Copy link
Member Author

@dnesbitt61 noted that we should maybe not do this change and see if in fact the tagging is just incorrect at airports. I am going to confirm the maybe the tag should be access=no vs access=private at a few airports.

@gknisely
Copy link
Member Author

gknisely commented Oct 30, 2019

checked a few airports. all use access=private and highway=service

@gknisely gknisely merged commit d8f27bb into master Oct 30, 2019
@purew purew deleted the private_access branch February 13, 2020 19:21
@gknisely gknisely removed the WIP label Apr 29, 2020
@gknisely gknisely mentioned this pull request Mar 11, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants