Fix search_cutoff check in loki correlate_node #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danpaz yep you could do exactly this check in search.cc test. basically make a test where the input location is on the edge. in the test we have a perfectly vertical edge so you can just vary the latitude until its the right distance away from the node. its pretty easy to check for. set node snap to like 100m and set search_cutoff to like 1 meter. |
kevinkreiser
reviewed
Nov 4, 2019
| @@ -259,9 +262,6 @@ struct bin_handler_t { | |||
| // cache the distance | |||
| if (distance == std::numeric_limits<float>::lowest()) | |||
| distance = node_ll.Distance(location.latlng_); | |||
| // the search cutoff is a hard filter so skip any outside of that | |||
| if (distance > location.search_cutoff_) | |||
| return; | |||
There was a problem hiding this comment.
this was my screw up back when we added search_cutoff. should have thought about that a little harder at the time. apologies!
kevinkreiser
previously approved these changes
Nov 4, 2019
|
Added a test in ba59cbd. I verified this test failed before the bugfix commit and passes now after the fix. |
kevinkreiser
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Previously, the correlate_node check in loki was incorrectly filtering out candidate edges that were outside the node_snap_tolerance but within the search_cutoff. We were measuring the wrong distance for cutoff, from the correlated node to the input location rather than from the edge to the input location. This would result in no edges being found even if the location was directly on an edge.
@kevinkreiser any thoughts on how I might implement a regression test for this case?
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?