Fix refactor bug #2064
Merged
Fix refactor bug #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StopExpansion distance argument was removed during the refactor in 6492d3d. This restores the correct behaviour
purew
commented
Nov 20, 2019
| @@ -97,11 +97,11 @@ bool TimeDepForward::ExpandForward(GraphReader& graphreader, | |||
| if (trans->up()) { | |||
| hierarchy_limits_[node.level()].up_transition_count++; | |||
| found_valid_edge = ExpandForward(graphreader, trans->endnode(), pred, pred_idx, true, | |||
| seconds_of_week, localtime, destination, best_path) || | |||
| localtime, seconds_of_week, destination, best_path) || | |||
There was a problem hiding this comment.
This mixup of the order of localtime and seconds_of_week seems to have been in the code for over a year?
There was a problem hiding this comment.
oops! Good catch. This code was never well tested (my only defense/excuse).
There was a problem hiding this comment.
i swear i fixed this myself a cuople months ago...
purew
commented
Nov 20, 2019
| found_valid_edge; | ||
| } else if (!hierarchy_limits_[trans->endnode().level()].StopExpanding()) { | ||
| } else if (!hierarchy_limits_[trans->endnode().level()].StopExpanding(pred.distance())) { |
There was a problem hiding this comment.
I introducted this bug during the refactor in 6492d3d
kevinkreiser
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?