Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Junction Name from OSRM Origin Maneuver #2121

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Conversation

kdiluca
Copy link
Member

@kdiluca kdiluca commented Dec 18, 2019

Updated the osrm serializer to not set junction name for osrm origin/start maneuver and added pinpoint tests.

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.

Tasklist

  • Add tests
  • Review - you must request approval to merge any PR to master
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog
  • Update relevant documentation

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

dgearhart
dgearhart previously approved these changes Dec 18, 2019
Copy link
Member

@dgearhart dgearhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@kdiluca kdiluca self-assigned this Dec 19, 2019
@kdiluca kdiluca merged commit 6d1572c into master Dec 19, 2019
yuzheyan added a commit that referenced this pull request Dec 19, 2019
* master:
  Remove Junction Name from OSRM Origin Maneuver (#2121)
@nilsnolde nilsnolde deleted the kdiluca-junction branch February 24, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants