prevent calling path_map_match when path_edges are empty. #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
approved these changes
Feb 7, 2020
yuzheyan
added a commit
that referenced
this pull request
Feb 7, 2020
* master: prevent calling path_map_match when path_edges are empty. (#2219) Disable alt_name processing (#2213) nomenclature update for intersection geom index serialize transition time at intersections (#2207) Add guidance view capability (#2209) RAD scripts fixes (#2199) Add multi run RAD script (#2206)
yuzheyan
added a commit
that referenced
this pull request
Feb 11, 2020
* master: missed leg weight to 3 decimal places (#2227) Zero Distance Match Leg Causes Nan Duration (#2229) Fixed the sharp turn phrase (#2226) Cleanup in test Cleanup whitespace in directions.proto Cleanup unused argument etp in narrativebuilder Code review feedback: test vector references, style nit Update to front and back. j/k: move TrimBuild to other geometry utilities. Test coverage, export TrimShape into header namespace; check for empty shape. Strip const from primitive types. Fix pointer invalidation bug in TrimShape. prevent calling path_map_match when path_edges are empty. (#2219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This is a duck fix to avoid seg fault. When the path edges are empty but there are valid match results, trace route attributes will fail since it try to access the path edges vector.
There are deeper issue to investigate other than prevent the seg fault happen. Working on the investigation now (why we return valid match results without path edges in the shortest path finding)