Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unlimited speed limits where maxspeed=none #2251

Merged
merged 10 commits into from
Mar 3, 2020
Merged

Support unlimited speed limits where maxspeed=none #2251

merged 10 commits into from
Mar 3, 2020

Conversation

danpaz
Copy link
Collaborator

@danpaz danpaz commented Feb 21, 2020 •
edited
Loading

Issue

Processes speed limits in OSM where maxspeed=none and sets the corresponding metadata on edgeinfo "speed_limit": "unlimited".

For example on the German autobahn maxspeed=none signifies there is no speed limit. Example in OSM.

image

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@danpaz danpaz requested a review from gknisely February 21, 2020 21:04
gknisely
gknisely requested changes Feb 21, 2020
View reviewed changes
src/mjolnir/pbfgraphparser.cc Outdated Show resolved Hide resolved
@danpaz
Copy link
Collaborator Author

danpaz commented Mar 2, 2020

Also updated the serializers for trace_attributes and locate to return "speed_limit": "unlimited" when maxspeed=none.

image

image

kevinkreiser
kevinkreiser reviewed Mar 2, 2020
View reviewed changes
src/mjolnir/osmway.cc Outdated Show resolved Hide resolved
mandeepsandhu
mandeepsandhu reviewed Mar 3, 2020
View reviewed changes
docs/speeds.md Outdated Show resolved Hide resolved
@danpaz danpaz merged commit c475b73 into master Mar 3, 2020
@danpaz danpaz deleted the maxspeed_none branch March 3, 2020 22:12
yuzheyan added a commit that referenced this pull request Mar 4, 2020
@yuzheyan
Merge branch 'master' into refactor_merge_segment
9357bca 
* master:
  Applies clang-tidy fixes (#2091)
  Support unlimited speed limits where maxspeed=none (#2251)
@danpaz danpaz mentioned this pull request Mar 10, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkreiser kevinkreiser kevinkreiser left review comments

@dnesbitt61 dnesbitt61 dnesbitt61 left review comments

@mandeepsandhu mandeepsandhu mandeepsandhu left review comments

@dgearhart dgearhart dgearhart left review comments

@gknisely gknisely gknisely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danpaz @kevinkreiser @dnesbitt61 @gknisely @mandeepsandhu @dgearhart