Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exit logic for non-motorways #2252

Merged
merged 11 commits into from
Feb 24, 2020
Merged

Update exit logic for non-motorways #2252

merged 11 commits into from
Feb 24, 2020

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented Feb 21, 2020 •
edited
Loading

Issue

Some non-motorway maneuvers should have an exit maneuver type instead of a ramp maneuver type when the link edges do not lead to a motorway

Example 1

-j '{"locations":[{"lat":39.100433,"lon":-77.537178,"street":"VA 7"},{"lat":39.111874,"lon":-77.537773,"street":"US 15 North"}],"costing":"auto","units":"miles"}'

image

< BEFORE
< Take the US 15 North ramp toward Frederick Maryland.
> AFTER
> Take the US 15 North exit toward Frederick Maryland.

VA7_US15N

Example 2

-j '{"locations":[{"lat":40.405930,"lon":-76.582314,"street":"US 22 East"},{"lat":40.408085,"lon":-76.580902,"street":"Fisher Avenue"}],"costing":"auto","units":"miles"}'

image

< BEFORE
< Take the PA 934 ramp toward I 81/Fort Indiantown Gap/Annville.
> AFTER
> Take the PA 934 exit toward I 81/Fort Indiantown Gap/Annville.

US22_PA934

This change improves 24% of our sample routes

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this Feb 21, 2020
danpaz
danpaz previously approved these changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@danpaz danpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, LGTM.

test/instructions.cc
"Take the ramp toward Pennsylvania Avenue.", "");
"Take the PA 283 West ramp toward Harrisburg.",
"Take the Pennsylvania 2 83 West ramp.",
"Take the Pennsylvania 2 83 West ramp toward Harrisburg.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this test change? Should we keep the old test in place and add a new one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old test was just a turn channel onto Pennsylvania Ave - not a ramp - therefore, needed to change the test
image
image

@dgearhart dgearhart merged commit 4e8b948 into master Feb 24, 2020
@dgearhart dgearhart deleted the update_exit_logic branch February 24, 2020 17:55
yuzheyan added a commit that referenced this pull request Mar 3, 2020
@yuzheyan
adding member variables to EdgeSegment and refactoring MergeRoute to …
1720e3d 
…populate the segments

* master:
  Transition matching (#2258)
  Post merge feedback on #2253. (#2257)
  Check for complex restriction where bidirectional expansion meets (#2242)
  Update README.md
  Configurable load testing of /route and /trace_route endpoints (via wrk) (#2253)
  Polyline Resampling Addition and Bug Fix (#2239)
  Update exit logic for non-motorways (#2252)
  Add app. to get a list of elevation tiles that are covered within the (#2248)
  Fix RapidJSON warnings and naming conflicts (#2249)
  Add basic truck costing documentation (#2241)

# Conflicts:
#	test/mapmatch.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpaz danpaz danpaz approved these changes

Assignees

@dgearhart dgearhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgearhart @danpaz