ref and directional fixes #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdiluca
approved these changes
Apr 6, 2020
yuzheyan
added a commit
that referenced
this pull request
Apr 16, 2020
* master: Refactor some functions for easier re-use. (#2302) typo in bitfield struct directededge (#2301) Re-enables changelog validation (#2294) ref and directional fixes (#2298) Add resample_distance (#2261) Fix Some ASAN Bugs (#2296) Update codecov ignore directory to third_party (#2297) Per location search filters for functional road class and forms of way (#2289) Adds traffic::Tile accessor function to GraphTile (#2295) Properly set the not_thru_pruning flag on the destination edge (just as (#2291) Range updates for datetime and emergency updates. (#2290)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Found a few issues with the initial ref and direction logic for ways. We were overwriting the refs with directionals to the name_offset_map instead of concatenating them together. Also, we did not allow for blank entries for GetTagTokens.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?