Temporary fix for trace_route crash #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterate past the end of match_results.
| @@ -446,6 +446,11 @@ thor_worker_t::map_match(Api& request) { | |||
| // (NOTE that, in between edges may have same edge id with the last edge) right before where | |||
| // discontinuity occurs | |||
| auto prev_match_result = match_result_itr++; | |||
| if (match_result_itr >= match_results.cend()) { | |||
There was a problem hiding this comment.
we are in the middle of refactoring this, so i think this is good enough for now until the refactor lands (which will delete all this extremely error-prone code)
kevinkreiser
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check match_result_itr after it is incremented to make sure it doesn't iterate past the end of match_results. Note - this is just a quick fix to throw an exception rather than causing a crash. There may be more graceful ways to continue forming the path.
fixes #2321
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?