Fix Lua handling of decimal values with zero mantissa #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ua 5.1/5.2 drop the .0 part when serializing (but not Lua 5.3 for some reason).
6 tasks
purew
reviewed
May 6, 2020
| } | ||
| } // namespace | ||
|
|
||
| // TODO: sweet jesus add more tests of this class! |
There was a problem hiding this comment.
we do have a test suite of lua tag transforms. we just do it through the parsing stage so that it makes a whole round trip (osm.pbf -> valhalla::osmdata . see test/graphparser.cc
…lhalla into danpat_fix_lua_zero_mantissa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2032
Deprecates #2066
Unblocks #2352
Fixes a bug where decimal numbers with a zero-sized mantissa don't serialize to the same original string in Lua 5.1/5.2, leading to incorrect string offsets being calculated when looking for string suffixes.
Ultimately, the bug manifests in tags like
maxheight: 2.0being incorrectly transformed intomaxheight: 0.611, instead ofmaxheight: 2.The fix is to continue treating "numeric_prefix" as a string up until it needs to be converted to a number (e.g. for multiplication), but not before.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?