Add sk-SK.json (slovak) localization file #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matus123 thank you so much for this! |
danpaz
reviewed
May 15, 2020
locales/sk-SK.json
Outdated
| "verbal_multi_cue": { | ||
| "phrases": { | ||
| "0": "<CURRENT_VERBAL_CUE> Potom <NEXT_VERBAL_CUE>", | ||
| "1": "<CURRENT_VERBAL_CUE> Then, in <LENGTH>, <NEXT_VERBAL_CUE>" |
There was a problem hiding this comment.
Should this be <CURRENT_VERBAL_CUE> Potom do <LENGTH>, <NEXT_VERBAL_CUE> ?
There was a problem hiding this comment.
My bad, i will fix this
|
Thank you @matus123! @dgearhart can you reconcile this with #2378 once it's merged? |
|
I can create new PR where i replace newly created placeholders from #2378 after it gets merged. |
dgearhart
approved these changes
May 15, 2020
dgearhart
added a commit
that referenced
this pull request
May 15, 2020
dgearhart
added a commit
that referenced
this pull request
May 16, 2020
* Extended the enter roundabout phrases to include the post roundabout street names and signs * Extended gurka to have the expect_instructions_at_maneuver_index method. Added roundabout instructions gurka tests Fixed street name assignemtn in the NarrativeBuilder::FormEnterRoundaboutInstruction method * Added the toward phrase to the exit_roundabout and exit_roundabout_verbal phrase blocks. Updated the narrative dictionary and builder for the new phrases. Added named roundabout gurka tests. * Fixed typo * switched to ASSERT * clean up * more clang tidy clean up * Updated the following phrase blocks for sk-SK.json: enter_roundabout, enter_roundabout_verbal, exit_roundabout, exit_roundabout_verbal * updated changelog for #2376 and 2378 * added a missing include * Only enhance empty street names if enter/exit are combined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2375
Adding slovak localization file.
I tested it with manual build from source.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?