Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the remaining guide sign toward phrases #2389

Merged
merged 11 commits into from
May 26, 2020
Merged

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented May 26, 2020

Issue

Add guide sign toward phrases for the following phrase blocks:

  1. keep
  2. keep_verbal
  3. merge
  4. merge_verbal
  5. enter_ferry
  6. enter_ferry_verbal

Example#1

image

< BEFORE
< 33: Keep right to take A-66/Autovía Ruta de la Plata.
<    VERBAL_ALERT: Keep right to take A-66.
<    VERBAL_PRE: Keep right to take A-66, Autovía Ruta de la Plata.
> AFTER
> 33: Keep right toward A-66/León/Oviedo/A-52.
>    VERBAL_ALERT: Keep right toward A-66.
>    VERBAL_PRE: Keep right toward A-66, León.

Example#2

< BEFORE
< 3: Merge left.
<    VERBAL_PRE: Merge left.
> AFTER
> 3: Merge left toward US 22/Ebensburg/Hollidaysburg.
>    VERBAL_PRE: Merge left toward U.S. 22, Ebensburg.

Tasklist

  • RAD tests
  • Add gurka tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

@dgearhart dgearhart self-assigned this May 26, 2020
@dgearhart dgearhart changed the title Add the remaining toward phrases Add the remaining guide sign toward phrases May 26, 2020
///////////////////////////////////////////////////////////////////////////////
// Keep right toward
// "4": "Keep <RELATIVE_DIRECTION> toward <TOWARD_SIGN>."
TEST_F(InstructionsKeepToward, KeepRightToward) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a test for KeepLeftToward?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danpaz yes, i will add

}
};

gurka::map InstructionsMergeToward::map = {};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danpaz yes, static class member

Copy link
Collaborator

@danpaz danpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gurka tests look great 👍 Approved

@dgearhart dgearhart merged commit 85bce6c into master May 26, 2020
@dgearhart dgearhart deleted the remaining_toward_phrases branch May 26, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants