-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the remaining guide sign toward phrases #2389
Conversation
/////////////////////////////////////////////////////////////////////////////// | ||
// Keep right toward | ||
// "4": "Keep <RELATIVE_DIRECTION> toward <TOWARD_SIGN>." | ||
TEST_F(InstructionsKeepToward, KeepRightToward) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a test for KeepLeftToward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danpaz yes, i will add
} | ||
}; | ||
|
||
gurka::map InstructionsMergeToward::map = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danpaz yes, static class member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gurka tests look great 👍 Approved
Issue
Add guide sign toward phrases for the following phrase blocks:
Example#1
Example#2
Tasklist