Add utility functions to Signs class #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added utility functions to Signs that return a list of signs instead of a string but are functionally similar to ListToString & GetGuideString APIs. These APIs can be used in place of the string variants when we want to control how the individual signs are used. Added tests for the new APIs.
mandeepsandhu
force-pushed
the
signs_utility_functions
branch
from
ff6eceb
to
b144903
Compare
dgearhart
reviewed
May 27, 2020
CHANGELOG.md
Outdated
| @@ -51,6 +51,7 @@ | |||
| * FIXED: Seeing segfault when loading large osmdata data files before loading LuaJit. LuaJit fails to create luaL_newstate() Ref: [#2158](https://github.com/ntop/ntopng/issues/2158) Resolution is to load LuaJit before loading the data files. [#2383](https://github.com/valhalla/valhalla/pull/2383) | |||
|
|
|||
| * **Enhancement** | |||
| * ADDED: Add utility functions to Signs. [#2390](https://github.com/valhalla/valhalla/pull/2390) | |||
There was a problem hiding this comment.
i think these are added at the end
dgearhart
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added utility functions to Signs that return a list of signs instead of
a string but are functionally similar to ListToString & GetGuideString
APIs.
These APIs can be used in place of the string variants when we want to
control how the individual signs are used.
Added tests for the new APIs.