-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese locale, update German #2432
Conversation
locales/de-DE.json
Outdated
@@ -2095,19 +2095,19 @@ | |||
"verbal_multi_cue": { | |||
"phrases": { | |||
"0": "<CURRENT_VERBAL_CUE> Dann <NEXT_VERBAL_CUE>", | |||
"1": "<CURRENT_VERBAL_CUE> Then, in <LENGTH>, <NEXT_VERBAL_CUE>" | |||
"1": "<CURRENT_VERBAL_CUE> Dann, in<LENGTH>, <NEXT_VERBAL_CUE>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verifying no space after in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah thats a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 28a9e26.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment - otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EXIT_NUMBERS
changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Issue
Adds support for Japanese. Thank you to Inamori Megumi for authoring the translation file and @tsuz for reviewing.
Also updates the German locale with new translations. Thanks to @AnnaStaley and @kevinkreiser for reviewing.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?