Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese locale, update German #2432

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Add Japanese locale, update German #2432

merged 5 commits into from
Jun 23, 2020

Conversation

danpaz
Copy link
Collaborator

@danpaz danpaz commented Jun 23, 2020

Issue

Adds support for Japanese. Thank you to Inamori Megumi for authoring the translation file and @tsuz for reviewing.

Also updates the German locale with new translations. Thanks to @AnnaStaley and @kevinkreiser for reviewing.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@@ -2095,19 +2095,19 @@
"verbal_multi_cue": {
"phrases": {
"0": "<CURRENT_VERBAL_CUE> Dann <NEXT_VERBAL_CUE>",
"1": "<CURRENT_VERBAL_CUE> Then, in <LENGTH>, <NEXT_VERBAL_CUE>"
"1": "<CURRENT_VERBAL_CUE> Dann, in<LENGTH>, <NEXT_VERBAL_CUE>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verifying no space after in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thats a typo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 28a9e26.

dgearhart
dgearhart previously approved these changes Jun 23, 2020
Copy link
Member

@dgearhart dgearhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment - otherwise :shipit:

mandeepsandhu
mandeepsandhu previously approved these changes Jun 23, 2020
Copy link
Contributor

@mandeepsandhu mandeepsandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EXIT_NUMBERS changes look good.

@danpaz danpaz dismissed stale reviews from mandeepsandhu and dgearhart via 180674c June 23, 2020 19:55
Copy link
Member

@dgearhart dgearhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@danpaz danpaz merged commit 1a686f5 into master Jun 23, 2020
@danpaz danpaz deleted the update_languages branch June 23, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants