Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing nullptr checks in graphreader and loki::Reach #2504

Merged
merged 3 commits into from
Jul 30, 2020

Conversation

mskurydin
Copy link
Member

@mskurydin mskurydin commented Jul 29, 2020

Issue

Routing could segfault if tiles of not all levels are loaded for a certain point (in reach)

This is a reduced version of #2493 (which is done from the fork)

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@mskurydin mskurydin marked this pull request as ready for review July 29, 2020 17:36
kevinkreiser
kevinkreiser previously approved these changes Jul 29, 2020
Routing could segfault if tiles of not all levels are loaded for a certain point (in reach)
@mskurydin
Copy link
Member Author

Did a clean rebase on the top of the latest commit

@kevinkreiser kevinkreiser merged commit cb31edf into master Jul 30, 2020
@kevinkreiser kevinkreiser deleted the ms-fix-null-ptr-crashes branch August 19, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants