Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve german destination_verbal_alert phrases #2509

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Improve german destination_verbal_alert phrases #2509

merged 2 commits into from
Jul 30, 2020

Conversation

danpaz
Copy link
Collaborator

@danpaz danpaz commented Jul 30, 2020

Issue

Tweaks the German localization destination_verbal_alert phrases. Improves the alert instruction to be more sensible when combined with the approach_verbal_alert phrase In <LENGTH>, <CURRENT_VERBAL_CUE>.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@danpaz danpaz requested a review from kevinkreiser July 30, 2020 16:53
@kevinkreiser kevinkreiser merged commit b80009f into master Jul 30, 2020
@danpaz danpaz deleted the improve_de branch August 19, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danpaz @kevinkreiser