Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Maneuvers (scenario2) #2741

Merged
merged 13 commits into from
Jan 5, 2021
Merged

Conversation

kdiluca
Copy link
Member

@kdiluca kdiluca commented Dec 17, 2020

Issue

This PR fixes an issue in guidance where we add an extra maneuver. This PR combines a current maneuver short length non-internal edges (left or right) with next maneuver that is a kRampStraight.

This will fix number 2 in mapbox/nav-api-intake#96

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

…t) with next maneuver that is a kRampStraight
@kdiluca kdiluca self-assigned this Dec 17, 2020
@kdiluca kdiluca requested a review from dgearhart January 4, 2021 19:02
@kdiluca
Copy link
Member Author

kdiluca commented Jan 4, 2021

Only expected diffs:

image

image
image
image
image

@dgearhart
Copy link
Member

Tests are looking good - I am running one more set
@kdiluca remember to update the changelog

Copy link
Member

@dgearhart dgearhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kdiluca kdiluca merged commit 082e492 into master Jan 5, 2021
@nilsnolde nilsnolde deleted the kdiluca-collapseTurns-scenario2 branch February 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants