Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject using std::locale for tiles path #2760

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Conversation

averkhaturau
Copy link
Contributor

@averkhaturau averkhaturau commented Jan 6, 2021

Issue

Improve no-RTTI compatibility. In GCC std::local c-tor may throw unhandled exception if compiled with -fno-rtti

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@averkhaturau averkhaturau marked this pull request as ready for review January 6, 2021 18:42
src/baldr/graphtile.cc Outdated Show resolved Hide resolved
src/baldr/graphtile.cc Outdated Show resolved Hide resolved
src/baldr/graphtile.cc Outdated Show resolved Hide resolved
@averkhaturau averkhaturau merged commit a463c5b into master Jan 12, 2021
@averkhaturau averkhaturau deleted the av-no-rtti-fixes branch January 13, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants