Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use thread-safe GraphTile's reference counter #2772

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Add option to use thread-safe GraphTile's reference counter #2772

merged 1 commit into from
Jan 14, 2021

Conversation

SiarheiFedartsou
Copy link
Member

@SiarheiFedartsou SiarheiFedartsou commented Jan 13, 2021 •
edited by averkhaturau
Loading

Issue

Sometimes we need to use the same instance of GraphTile from different threads. This PR adds compile-time option to make GraphTile's reference counter thread-safe.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Generally use squash merge to rebase and clean comments before merging
  • Update the changelog

Requirements / Relations

#2730

@SiarheiFedartsou SiarheiFedartsou marked this pull request as ready for review January 13, 2021 09:48
averkhaturau
averkhaturau previously approved these changes Jan 13, 2021
View reviewed changes
kevinkreiser
kevinkreiser reviewed Jan 13, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
kevinkreiser
kevinkreiser previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the changelog entry on the wrong end of the list, this looks good to me

@averkhaturau averkhaturau dismissed stale reviews from kevinkreiser and themself via 5adc4cb January 14, 2021 06:12
@averkhaturau averkhaturau force-pushed the sf-thread-safe-counter branch 2 times, most recently from 5adc4cb to 473c078 Compare January 14, 2021 06:18
@averkhaturau
Add option to use thread-safe GraphTile's reference counter
13caf79 
Update CHANGELOG.md

TileRefCounter -> GraphTileRefCounter
@SiarheiFedartsou SiarheiFedartsou merged commit a43fb81 into master Jan 14, 2021
@dnesbitt61 dnesbitt61 mentioned this pull request Feb 16, 2021
Open
@averkhaturau averkhaturau deleted the sf-thread-safe-counter branch April 26, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averkhaturau averkhaturau averkhaturau approved these changes

@kevinkreiser kevinkreiser kevinkreiser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SiarheiFedartsou @kevinkreiser @averkhaturau