-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SacScale to trace_attributes output #2818
Conversation
…directededge output on locate.
@dnesbitt61 MinGW64 build is failing |
…turn values for trace_attributes.
MinGW64 issue:
I'm not sure what (if anything I would have done to cause this!) |
@dnesbitt61 i think that’s a pretty random thing right now.. smth in rawhide got messed up is my guess.. my win ninja PR kept failing randomly while I was only updating the azure config. I think it’s safe to ignore it right now.. I’ll see if I can move that CI to a stable fedora version |
@dnesbitt61 this looks good to me. can we hack in a quick gurka test to verify it, should be pretty quick. gurka supports trace_attributes, i added that pretty recently i believe |
I do not see any gurka examples using trace_attributes action or any expect_* methods to evaluate results. Am I missing something? |
@dnesbitt61 we now have a |
@dnesbitt61 dont forget to run the format script |
the new test fails with: |
this test now works. Good thing, I was missing one of the sac scales in the proto conversion which led to some incorrect values. One problem - I use auto costing. If I change to pedestrian there is only 1 edge in the result. |
@dnesbitt61 i suspect this could be because of costing that pedestrian only gets one edge. i reckon that our walking costing, by default, avoids hardcore hiking which i think in your test is in the middle of the route. you can modify the costing options to allow for an alpine sac scale in the test if you want to expand the test to do pedestiran as well. let me know i can take a crack at it and then we can merge it |
…set to allow difficult hiking (high sac_scale ways).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me @gknisely are you good too?
Issue
trace_attributes does not output SacScale (hiking difficulty). This PR adds SacScale to the edge attributes output from trace_attributes. In addition, the sac_scale value of a directed edge is output in the JSON for locate actions.
The following simple request illustrates the output:
http://localhost:8002/trace_attributes?json={"shape":[{"lat": 44.184851, "lon": 7.170174},{"lat": 44.184435, "lon": 7.173414}],"shape_match":"map_snap", "costing":"bicycle"}
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?