Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly tarball indices should not require write permissions #2822

Merged
merged 6 commits into from
Feb 2, 2021

Conversation

LaGrunge
Copy link
Contributor

No description provided.

@LaGrunge
Copy link
Contributor Author

It seems Valhalla MinGW Build is broken inside environment setup
Problem: conflicting requests

  • nothing provides mingw64(api-ms-win-core-synch-l1-2-0.dll) needed by mingw64-boost-1.75.0-1.fc34.noarch

@LaGrunge LaGrunge force-pushed the master branch 2 times, most recently from 60fa08c to a2ce373 Compare January 29, 2021 14:20
@mandeepsandhu
Copy link
Contributor

It seems Valhalla MinGW Build is broken inside environment setup
Problem: conflicting requests

  • nothing provides mingw64(api-ms-win-core-synch-l1-2-0.dll) needed by mingw64-boost-1.75.0-1.fc34.noarch

Yes, you can ignore mingw64 build failures for now (the build environment is broken).

@LaGrunge
Copy link
Contributor Author

  • nothing provides mingw64(api-ms-win-core-synch-l1-2-0.dll) needed by mingw64-boost-1.75.0-1.fc34.noarch
    Yes, you can ignore mingw64 build failures for now (the build environment is broken).

Thank you! I have rebased my branch for current head, looking forward for review and possible merge

Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changlelog entry need moved up to the new section I believe

@kevinkreiser kevinkreiser merged commit 4cb9a2f into valhalla:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants