Conditional access restriction update #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const gurka::ways ways = { | ||
| {"AD", | ||
| {{"highway", "service"}, | ||
| {"motorcar", "no"}, | ||
| {"bicycle", "yes"}, | ||
| {"foot", "yes"}, | ||
| {"bicycle:conditional", timeDenied}, | ||
| {"foot:conditional", timeAllowed}}}, | ||
| {"bicycle:conditional", yesAllowed}, |
There was a problem hiding this comment.
The restriction changed from "denied" to "allowed" but none of the tests below needed to be changed? So for the time it was denied would need to have its test changed, no?
There was a problem hiding this comment.
@mandeepsandhu before we only tested for the yes attribute. So I added the others in randomly for the tests regardless of the mode as it hits the same code. If we don't encounter one of those values we default to denied.
cp and paste fail
mandeepsandhu
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
added support for destination for conditional access restrictions
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?