Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python bindings to full mac os ci build #3013

Merged
merged 4 commits into from Apr 17, 2021
Merged

Conversation

nilsnolde
Copy link
Member

Let's see if this runs on the first try..

somehow weird that boost-python would install all the other boost libs needed for valhalla, notably the binary program_options..
@nilsnolde
Copy link
Member Author

of course not..

looks like boost-python had bpo as dependency.. can't seem to find a brew way to install only bpo. I'll install whole boost, let me know if you'd prefer only boost-python, which seemed to work as well.

…t CMake found a python < 3.6: change the test's CMake find_package and print the executable path
@nilsnolde
Copy link
Member Author

finally works, good to go..

@nilsnolde nilsnolde requested a review from danpat April 17, 2021 13:54
Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kevinkreiser kevinkreiser merged commit 8baea9b into master Apr 17, 2021
@nilsnolde nilsnolde deleted the nn_mac_py_ci branch February 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants