Nutiteq connectivity map construction #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap constructor. This allows using custom graphreader instances that are not constructed from property tree parameters. Also fix a locking issue in incident_singleton.
merkispavel
approved these changes
May 3, 2021
There was a problem hiding this comment.
I thought about committing lint fix to the #3045. Now I see that I couldn't do it because of the branch from the fork.
Thanks @kevinkreiser!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3045
#3045 needed linted but i wasnt able to manually do it to the existing branch so i pulled the commits into this branch and pr'd it separately