Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heading on small edge #3114

Merged
merged 5 commits into from
May 28, 2021
Merged

Fix heading on small edge #3114

merged 5 commits into from
May 28, 2021

Conversation

dgearhart
Copy link
Member

@dgearhart dgearhart commented May 27, 2021 •
edited
Loading

Issue

Fix begin/end heading on small edge where the heading is not set properly

Example

< BEFORE
< 2: Keep right to take Boltív köz.
> AFTER
> 2: Turn left onto Boltív köz.

image

This improved 3% of user routes

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the changelog

@dgearhart dgearhart self-assigned this May 28, 2021
mandeepsandhu
mandeepsandhu approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@mandeepsandhu mandeepsandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dgearhart dgearhart merged commit dfe0c31 into master May 28, 2021
@dgearhart dgearhart deleted the begin_heading branch January 5, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gknisely gknisely gknisely approved these changes

@mandeepsandhu mandeepsandhu mandeepsandhu approved these changes

Assignees

@dgearhart dgearhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgearhart @gknisely @mandeepsandhu