oneway support for pedestrian access and foot restrictions #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and getting the bits.
…ay:foot will modify any type of way.
gknisely
changed the title
gknisely
changed the title
gknisely
commented
Jun 15, 2021
| @@ -1173,10 +1197,15 @@ function filter_tags_generic(kv) | |||
| kv["moped_backward"] = kv["moped_forward"] | |||
| end | |||
|
|
|||
| if (kv["motorcycle_backward"] == "false" and (kv["oneway:motorcycle"] == nil or oneway[kv["oneway:motorcycle"]] == false or kv["oneway:motorcycle"] == "no")) then | |||
There was a problem hiding this comment.
Small update. Found a bug via the new gurka test
gknisely
commented
Jun 15, 2021
| @@ -1237,6 +1270,24 @@ function filter_tags_generic(kv) | |||
| kv["bike_backward"] = forwards | |||
| end | |||
|
|
|||
| if (kv["oneway:moped"] == "-1" or kv["oneway:mofa"] == "-1") then | |||
There was a problem hiding this comment.
More issues found via the gurka test from lines 1273 to 1283
gknisely
commented
Jun 15, 2021
| forward_access |= kWheelchairAccess; | ||
| reverse_access |= kWheelchairAccess; | ||
| if (way.use() != Use::kSteps) { | ||
| if (way.wheelchair_tag() && way.wheelchair()) { |
There was a problem hiding this comment.
Wheelchair routing and logic needs to be finished. This was started a long time ago but never finished.
gknisely
commented
Jun 15, 2021
| @@ -551,14 +551,17 @@ bool PedestrianCost::Allowed(const baldr::DirectedEdge* edge, | |||
| const uint64_t current_time, | |||
| const uint32_t tz_index, | |||
| uint8_t& restriction_idx) const { | |||
| if (!IsAccessible(edge) || (edge->surface() > minimal_allowed_surface_) || edge->is_shortcut() || | |||
There was a problem hiding this comment.
Added restrictions check
gknisely
requested review from
dnesbitt61,
maksimandrianov,
merkispavel,
dgearhart and
SvetlanaBayarovich
merkispavel
previously approved these changes
Jun 15, 2021
dgearhart
reviewed
Jun 15, 2021
valhalla/mjolnir/osmway.h
Outdated
| @@ -1689,7 +1707,7 @@ struct OSMWay { | |||
| uint16_t use_sidepath_ : 1; | |||
| uint16_t bike_forward_ : 1; | |||
| uint16_t bike_backward_ : 1; | |||
| uint16_t spare1_ : 4; | |||
| uint16_t spare3_ : 4; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Allows support for oneway pedestrian ways.
Before. Via oneway. (Ignores oneway exit for a ride)
After. Via oneway.
Before. Ending on onway exit for a ride.
After. Ending on onway exit for a ride.
Before. Oneway footpath
After. Oneway footpath
Before. Foot restriction (enter only) Restriction ignored.
After. Foot restriction (enter only)
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?