Creating a single Sign protobuf object that can be used by both directions.proto and trip.proto. #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a single sign.proto that could be shared by trip.proto and directions.proto, since they are nearly the same.
dgearhart
previously requested changes
Jun 15, 2021
@dgearhart |
ktatterso
commented
Jun 15, 2021
| @@ -57,6 +49,14 @@ set(sources | |||
| set (sources_with_warnings | |||
| bssbuilder.cc | |||
| dataquality.cc | |||
| elevationbuilder.cc | |||
There was a problem hiding this comment.
These are the files not building on OSX with -Werror.
gknisely
previously approved these changes
Jun 16, 2021
gknisely
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both trip.proto and directions.proto have
SignandSignElementobjects that are very similar. I've unified these into sign.proto. No new tests are needed as existing tests should be sufficient for this refactor.Also, on Mac, -Werror is too strong for all of mjolnir, the Boost header
format.hfails to compile with -Werror. So I addressed that issue as well.Issue
A simple refactor. Will help in the future if we have functions/methods that extract
Signinformation. (I'm planning to do this exact thing in a near PR.)Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?