Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support popular access tags #3149

Merged
merged 2 commits into from
Jun 17, 2021
Merged

support popular access tags #3149

merged 2 commits into from
Jun 17, 2021

Conversation

CuriOusQuOkka
Copy link
Contributor

@CuriOusQuOkka CuriOusQuOkka commented Jun 16, 2021

Issue

Support popular tags for barrier and access

Tasklist

  • Add tests
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

@CuriOusQuOkka CuriOusQuOkka force-pushed the support_tags branch 6 times, most recently from e332d48 to d0024e3 Compare June 17, 2021 11:15
@CuriOusQuOkka CuriOusQuOkka marked this pull request as ready for review June 17, 2021 11:36
@CuriOusQuOkka CuriOusQuOkka changed the title support popular tags for barrier and access support popular access tags Jun 17, 2021
lua/graph.lua Outdated
@@ -121,9 +127,7 @@ sidewalk = {
["this"] = "true",
["detached"] = "false",
["raised"] = "true",
["separate_double"] = "false",
["sidepath"] = "false",
Copy link
Member

@gknisely gknisely Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CuriOusQuOkka why was sidepath, separate_double, and explicit removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an accident, fixed. Thanks

@CuriOusQuOkka CuriOusQuOkka merged commit 42ed61c into master Jun 17, 2021
@CuriOusQuOkka CuriOusQuOkka deleted the support_tags branch December 18, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants