Trip sign proto refactor #3168
Merged
Trip sign proto refactor #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a single sign.proto that could be shared by trip.proto and directions.proto, since they are nearly the same.
…d with valhalla::baldr::Sign.
gknisely
approved these changes
Jun 24, 2021
This was referenced Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Moving the protobuf
Signobject tovalhalla::Signled to confusion and bad things due to it being mixed up withvalhalla::baldr::Sign. So I've renamed the protobuf version toTripSign. Also renamed the protobufSignElementtoTripSignElement.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?