-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added stop and give_way/yield signs to the data and traffic signal fixes. #3251
Conversation
…uld be at the minor roads
…e transition index so that we know if we have a stop or yield sign will be processed and removed in the enhancer
…so, shut off traffic signals if oneway edge and no forward access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didnt thoroughly review the rest but you have to at least make the change in directededge bitfields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the whole "minor" logic but trust you tested all of this thoroughly
@dnesbitt61 Let me explain. If there is a k/v pair Yes tested. Even created tests for traffic_signals too as they were missing. Next step will be stop impact updates an guidance changes. |
Issue
This PR is the initial logic that is needed so that we can call out stop and give_way/yield signs in the narrative. For example, "Turn right at the stop sign to continue on xyz Road."
I tried to use the logic that already existed for traffic signals; however, I found a bug with how they are marked. Therefore, I fixed the issue and added tests for traffic signals.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?