Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stop and give_way/yield signs to the data and traffic signal fixes. #3251

Merged
merged 31 commits into from
Aug 9, 2021

Conversation

gknisely
Copy link
Member

@gknisely gknisely commented Aug 5, 2021

Issue

This PR is the initial logic that is needed so that we can call out stop and give_way/yield signs in the narrative. For example, "Turn right at the stop sign to continue on xyz Road."

I tried to use the logic that already existed for traffic signals; however, I found a bug with how they are marked. Therefore, I fixed the issue and added tests for traffic signals.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

…e transition index so that we know if we have a stop or yield sign will be processed and removed in the enhancer
…so, shut off traffic signals if oneway edge and no forward access.
@gknisely gknisely changed the title Added stop and give_way/yield signs to the data. Traffic signal fixes. Added stop and give_way/yield signs to the data and traffic signal fixes. Aug 5, 2021
Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt thoroughly review the rest but you have to at least make the change in directededge bitfields

Copy link
Member

@dnesbitt61 dnesbitt61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the whole "minor" logic but trust you tested all of this thoroughly

@gknisely
Copy link
Member Author

gknisely commented Aug 9, 2021

I don't understand the whole "minor" logic but trust you tested all of this thoroughly

@dnesbitt61 Let me explain. If there is a k/v pair stop=minor or give_way=minor we are supposed to assign the stop sign or give_way to only the edges that have a lower road class at the intersection. If minor does not exist, then we assign to all intersecting edges.

Yes tested. Even created tests for traffic_signals too as they were missing. Next step will be stop impact updates an guidance changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants