Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More real-world hov lane change/transition test case #3330

Merged
merged 5 commits into from Sep 22, 2021
Merged

Conversation

ktatterso
Copy link
Contributor

Issue

I was led to believe that the transition cost for getting onto/off-of an hov lane was too high. However, it was my test case that was not "real world" enough.

I've modified my preexisting test case to make it more "real world". This means:

  • The distance between the highway lane and hov/hot lane is more realistic
  • The length and angle of entry/exit onto and off-of the hov/hot lane is more realistic
  • The hov lane itself would typically be much longer, but I didn't want to go too crazy
  • Entering the hov lane is (as convention) now a highway:motorway-link
  • Note that exiting the hov lane and reentering the highway is (as convention) not a link

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@ktatterso ktatterso marked this pull request as ready for review September 21, 2021 19:38
Copy link
Contributor

@CuriOusQuOkka CuriOusQuOkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktatterso ktatterso merged commit ef4565e into master Sep 22, 2021
@ktatterso ktatterso deleted the hov-tweaks branch September 22, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants