Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'tileset_modified_date' info to /status endpoint #3367

Merged
merged 7 commits into from
Oct 25, 2021
Merged

Conversation

nilsnolde
Copy link
Member

@nilsnolde nilsnolde commented Oct 22, 2021

fixes #3366

this was so quick, I just did it.

now the /status endpoint responds with version & tileset_last_modified, additional (and expensive) details about the tileset is still protected with verbose=true.

if you accept it, I can write 1-2 quick tests.

src/loki/status_action.cc Outdated Show resolved Hide resolved
src/loki/status_action.cc Outdated Show resolved Hide resolved
@nilsnolde
Copy link
Member Author

nice, would like to see a 5000 next to "Code" (msbuild compiler warnings maybe haha)

image

…d update incident singleton to use it. update graphreader to tell us where it is getting tiles
@nilsnolde
Copy link
Member Author

code changes make sense, thanks a ton @kevinkreiser ! (just one question regarding epoch)

I'll clean up a little (docs, tests etc), then it'd be good to go for me.

test/loki_service.cc Outdated Show resolved Hide resolved
@nilsnolde
Copy link
Member Author

loki_service /status coverage added back, thanks for the tips.

@nilsnolde nilsnolde merged commit 5656ca5 into master Oct 25, 2021
@nilsnolde nilsnolde changed the title add 'tile_age' info to /status endpoint add 'tileset_modified_date' info to /status endpoint Oct 25, 2021
@nilsnolde nilsnolde deleted the nn-add-data-age branch February 24, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "tile_age" to /status response
2 participants