overhaul python bindings #3380
Merged
overhaul python bindings #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bindings: dicts instead of str for requests, lowercase function names; integrate valhalla_build_config to final package
nilsnolde
commented
Oct 29, 2021
nilsnolde
commented
Oct 29, 2021
nilsnolde
commented
Oct 29, 2021
nilsnolde
commented
Oct 29, 2021
Comment on lines
+2
to
+7
| "mjolnir": { | ||
| "max_cache_size": 1000000000, | ||
| "id_table_size": 1300000000, | ||
| "use_lru_mem_cache": false, | ||
| "lru_mem_cache_hard_control": false, | ||
| "use_simple_mem_cache": false, |
There was a problem hiding this comment.
oops.. seems like that's the current output of valhalla_build_config.. or at least what the python json library makes of it. hope that's ok.
|
from my side this is done @kevinkreiser . no hurry here though, if we get it merged within the next 1-2 weeks that'd be cool. |
kevinkreiser
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3370
all things done from the issue. will comment more inline.
tests will fail. will migrate them to use
unittestas well (as the script tests do) once this has some initial approval