Reuse sample::get implementation #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merkispavel
commented
Dec 24, 2021
| @@ -212,7 +212,7 @@ class tile_data { | |||
| bool reusable; | |||
|
|
|||
| public: | |||
| tile_data() : c(nullptr), index(0), reusable(false), data(nullptr) { | |||
| tile_data() : c(nullptr), index(TILE_COUNT), reusable(false), data(nullptr) { | |||
There was a problem hiding this comment.
If I'm not mistaken - index=0 is actually a valid index. So it's better to fill it with invalid index value
merkispavel
commented
Dec 24, 2021
| template <class coords_t> std::vector<double> sample::get_all(const coords_t& coords) { | ||
| std::vector<double> values; | ||
| values.reserve(coords.size()); | ||
| uint16_t curIndex = TILE_COUNT; |
There was a problem hiding this comment.
tile_data already stores index so I just added tile_data::get_index getter to obtain it
kevinkreiser
reviewed
Jan 2, 2022
kevinkreiser
previously approved these changes
Jan 2, 2022
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
Sure thing! done |
kevinkreiser
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Previously we had duplicated logic for
sample::getandsample::get_all. The PRget(coord, tile&)(like we have in GraphReader)tile_dataindex to invalid value(i.eTILE_COUNTinstead of 0)Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?