-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docker image valhalla/valhalla:run-latest: conan error + python #3485
Conversation
------------------------------------- -- Conan: checking conan executable -- Conan: Found program /usr/local/bin/conan -- Conan: Version found Conan version 1.43.0 -- Conan executing: /usr/local/bin/conan install /usr/local/src/valhalla/conanfile.txt --remote conancenter --settings build_type=RelWithDebInfo --settings compiler=gcc --settings compiler.version=9 --settings compiler.libcxx=libstdc++11 --settings compiler.cppstd=14 ERROR: Not able to automatically detect '/usr/bin/cc' version ERROR: Unable to find a working compiler WARN: Remotes registry file missing, creating default one in /root/.conan/remotes.json -- Conan: Using autogenerated FindBoost.cmake -------------------------------------
expected with the python fix:
|
with the Conan fix:
|
note: Some Conan errors are still exists - in the other parts of the test/code. ( example: parallel-runs ) now:
|
Python stuff makes sense but I really don't get why you'd have to tell it to use gcc. It should find gcc just fine as it always has done. Also why isn't the build failing on master already? also the link to ci that you posted is osx which most definitely will not be using gcc but rather it uses clang. |
ok so looking at master on the latest build i do see (https://app.circleci.com/pipelines/github/valhalla/valhalla/8705/workflows/be970abd-0b6d-4e55-9c91-64f6ad2d4825/jobs/51155):
but the build proceeds regardless and seems to be fine. @ImreSamu are you really just worried about the error? at the moment we are just using conan to fetch header-only boost, so it technically wouldnt need to compile anything for us, we do that in our own build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specifying the compiler in this case doesnt matter to us since we arent using conan to compile anything, but also it doesnt hurt us in this case either. getting the built python module is a great catch, thank you for that!
Issue #3484
fix docker image: valhalla/valhalla:run-latest:
1.) Conan error in the docker build log. "ERROR: Unable to find a working compiler"
2.) The valhalla-python integration is missing in the final docker image.
Tasklist