Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker image valhalla/valhalla:run-latest: conan error + python #3485

Merged
merged 3 commits into from
Jan 2, 2022

Conversation

ImreSamu
Copy link
Contributor

@ImreSamu ImreSamu commented Jan 1, 2022

Issue #3484

fix docker image: valhalla/valhalla:run-latest:
1.) Conan error in the docker build log. "ERROR: Unable to find a working compiler"

2.) The valhalla-python integration is missing in the final docker image.

Tasklist

  • Add #fixes with the issue number that this PR addresses
  • Update the changelog

-------------------------------------
-- Conan: checking conan executable
-- Conan: Found program /usr/local/bin/conan
-- Conan: Version found Conan version 1.43.0
-- Conan executing: /usr/local/bin/conan install /usr/local/src/valhalla/conanfile.txt --remote conancenter --settings build_type=RelWithDebInfo --settings compiler=gcc --settings compiler.version=9 --settings compiler.libcxx=libstdc++11 --settings compiler.cppstd=14
ERROR: Not able to automatically detect '/usr/bin/cc' version
ERROR: Unable to find a working compiler
WARN: Remotes registry file missing, creating default one in /root/.conan/remotes.json
-- Conan: Using autogenerated FindBoost.cmake
-------------------------------------
@ImreSamu
Copy link
Contributor Author

ImreSamu commented Jan 1, 2022

expected with the python fix:

$ docker run -it --rm  valhalla/valhalla:run-latest python3 -c "import valhalla,sys; print (sys.version, valhalla)"

3.8.10 (default, Nov 26 2021, 20:14:08) 
[GCC 9.3.0] <module 'valhalla' from '/usr/lib/python3/dist-packages/valhalla/__init__.py'>

@ImreSamu
Copy link
Contributor Author

ImreSamu commented Jan 1, 2022

with the Conan fix:

-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11") 
-- No compatible boost version detected, using conan...
-- Conan: checking conan executable
-- Conan: Found program /usr/local/bin/conan
-- Conan: Version found Conan version 1.43.0
-- Conan executing: /usr/local/bin/conan install /usr/local/src/valhalla/conanfile.txt --remote conancenter --settings build_type=RelWithDebInfo --settings compiler=gcc --settings compiler.version=9 --settings compiler.libcxx=libstdc++11 --settings compiler.cppstd=14
WARN: Remotes registry file missing, creating default one in /root/.conan/remotes.json
-- Conan: Using autogenerated FindBoost.cmake
-- Found Boost: 1.71.0 (found suitable version "1.71.0", minimum required is "1.71") 

@ImreSamu
Copy link
Contributor Author

ImreSamu commented Jan 1, 2022

note: Some Conan errors are still exists - in the other parts of the test/code. ( example: parallel-runs )
so need to add to every cmake this workaround : cmake -DCMAKE_C_COMPILER=gcc .. ( or similar fix )

now:

-- Conan: checking conan executable
-- Conan: Found program /usr/local/bin/conan
-- Conan: Version found Conan version 1.44.0
-- Conan executing: /usr/local/bin/conan install /Users/distiller/project/conanfile.txt --remote conancenter --settings build_type=Release --settings compiler=apple-clang --settings compiler.version=11.0 --settings compiler.libcxx=libc++ --settings compiler.cppstd=14
ERROR: Not able to automatically detect '/Applications/Xcode-11.1.GM.Seed.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc' version
WARN: Remotes registry file missing, creating default one in /Users/distiller/.conan/remotes.json

https://app.circleci.com/pipelines/github/valhalla/valhalla/8710/workflows/b89f4a9e-8ca4-4789-85cf-f7487fce781f/jobs/51177/parallel-runs/0/steps/0-110

@kevinkreiser
Copy link
Member

kevinkreiser commented Jan 2, 2022

Python stuff makes sense but I really don't get why you'd have to tell it to use gcc. It should find gcc just fine as it always has done. Also why isn't the build failing on master already?

also the link to ci that you posted is osx which most definitely will not be using gcc but rather it uses clang.

@kevinkreiser
Copy link
Member

ok so looking at master on the latest build i do see (https://app.circleci.com/pipelines/github/valhalla/valhalla/8705/workflows/be970abd-0b6d-4e55-9c91-64f6ad2d4825/jobs/51155):

ERROR: Not able to automatically detect '/usr/bin/cc' version
ERROR: Unable to find a working compiler
WARN: Remotes registry file missing, creating default one in /root/.conan/remotes.json

but the build proceeds regardless and seems to be fine. @ImreSamu are you really just worried about the error? at the moment we are just using conan to fetch header-only boost, so it technically wouldnt need to compile anything for us, we do that in our own build.

Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifying the compiler in this case doesnt matter to us since we arent using conan to compile anything, but also it doesnt hurt us in this case either. getting the built python module is a great catch, thank you for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants