Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xcode up to 12.4.0 #3492

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Update xcode up to 12.4.0 #3492

merged 6 commits into from
Jan 5, 2022

Conversation

merkispavel
Copy link
Contributor

@merkispavel merkispavel commented Jan 4, 2022

Issue

Circle is deprecating xcode 11 so we need to upgrade(see https://circleci.com/docs/2.0/testing-ios/)

tldr: xcode 12.4.0 works out of the box without any other fixes, the newest xcode doesn't

What about newest xcode version(13.12.1)

I tried different xcode versions. It looks like everything works smoothly on mac os 10.* while we need fixes for mac os 11(i.e xcode version >= 12.5.1)

What fixes do we need for the newest xcode?

  1. The first issue was six python package: six is installed by default and there's a conflict when you try to install protobuf via brew(six is a dependency of protobuf).
  • the fix is to remove default "six": pip3 uninstall -y six(see e3fb8e9)
  1. After that another issue popped up: prime server wasn't able to build successfully(see build logs)
m4/ax_pthread.m4:88: AX_PTHREAD is expanded from...
configure.ac:37: the top level
configure.ac:2: error: possibly undefined macro: m4_esyscmd
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: error: /usr/local/Cellar/autoconf/2.71/bin/autoconf failed with exit status: 1

At this moment I gave up and tried to decrease xcode version one more time. And it worked

fixes #3490

@merkispavel merkispavel changed the title Draft: try xcode 13.1.0 Update xcode up to 12.4.0 Jan 5, 2022
@merkispavel merkispavel marked this pull request as ready for review January 5, 2022 00:43
@merkispavel merkispavel mentioned this pull request Jan 5, 2022
@kevinkreiser kevinkreiser merged commit c34fd8f into master Jan 5, 2022
@purew purew deleted the try-not-latest-xcode branch January 5, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants