-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add json generator to conan #3493
Conversation
de92f4d
to
cecd8f4
Compare
i have a question about your other project that uses valhalla as a submodule. how are you including valhalla in that downstream cmake project? i have used |
Oh yeah, a cmake build wouldn’t be a problem. It’s a setuptools build for python, so I need all the include paths etc. it’s not even about building Valhalla itself, just about building the binding code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if its helpful to someone to have the generated json i dont mind!
can you re-approve @kevinkreiser ? thx! |
CHANGELOG.md
Outdated
* CHANGED: fix more protobuf unstable 3.x API [#3494](https://github.com/valhalla/valhalla/pull/3494) | ||
* CHANGED: fix more protobuf unstable 3.x API [#3494](https://github.com/valhalla/valhalla/pull/3494) & [#3501](https://github.com/valhalla/valhalla/pull/3501) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems duplicated with the next line that references both prs, do you want two separate or one with both in it. surely you dont want 3 references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 thanks!
... so downstream apps can use valhalla's conanfile.txt to know where boost is installed. there's no side effects except for an additional file, the cmake build should still work as before.
specifically I'm using valhalla as submodule and instead of generating another conanfile.txt I can use valhalla's if it exports the dependency tree as JSON.
this is what it looks like for valhalla currently:
conanbuildinfo.json
the command for a super-project where valhalla is in
./lib
:conan install --install-folder $PWD/conan_build --remote conancenter lib/valhalla