Only consider a road hov-only if both hov:designated and hov:minimum are correctly set #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et to consider a lane/road/way as hov-only.
ktatterso
changed the title
hov:designated and hov:minimum are both correctly s…
gknisely
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
An issue was found where a
waywas tagged withhov:designatedbut was missinghov:minimum. This exposed an issue that prevented all routing on the oddly tagged way.Now both
hov:designatedandhov:minimumhave to be correctly set for the way to be considered hov-only.I was able to modify an existing test to prove correctness.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?