Add serialized warnings array to JSON output #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oute endpoint json response
nilsnolde
reviewed
Apr 6, 2022
nilsnolde
reviewed
Apr 6, 2022
nilsnolde
reviewed
Apr 6, 2022
nilsnolde
reviewed
Apr 6, 2022
nilsnolde
reviewed
Apr 7, 2022
kevinkreiser
previously approved these changes
Oct 12, 2022
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
nilsnolde
previously approved these changes
Oct 12, 2022
nilsnolde
previously approved these changes
Oct 14, 2022
kevinkreiser
previously approved these changes
Oct 14, 2022
|
Think I’ll try to revert the changes to gurka here before merging |
nilsnolde
previously approved these changes
Oct 14, 2022
nilsnolde
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fixes #3099
Testing
cmake -B build -DENABLE_TESTS=ON cd build make run-gurka_warningsWhat issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?