Few admin fixes & suggestions #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
May 9, 2022
| @@ -141,7 +141,7 @@ function rels_proc (kv, nokeys) | |||
| end | |||
|
|
|||
| if kv["admin_level"] == "2" then | |||
| if kv["name"] == "France" then | |||
| if kv["name"] == "France" or kv["name"] == "United Kingdom" then | |||
There was a problem hiding this comment.
I think I just found it strange to think of england/scotland/wales as a state. the change suggestion is very similar to how the same, really, as we handle france IMO. we promote french territories to countries and throw away the french "kingdom"/empire. england etc don't have a concept of states, but they do some autonomy. plus scotland has its own national soccer team ;)
I also wanted to do the same with netherlands, but that's a mess in osm, wouldn't really work..
gknisely
approved these changes
May 9, 2022
|
once an admin db is built with this and a tileset is built with that admin, it could make the speeds we can apply with openstreetmapspeeds not work in these countries, right? that is to say, their country codes and states will be different. ill have to rerun that data so they apply but in the mean time i could just duplicate the great britian one 3 times i guess. also what does this do to northern ireland.. oh i see it works like the others cool. |
|
in case anyone thinks this broke master: I just accidentally canceled the build while cancelling the docs PR |
nilsnolde
added a commit
that referenced
this pull request
Jun 12, 2022
nilsnolde
added a commit
that referenced
this pull request
Jun 12, 2022
johannes-no
pushed a commit
to mercedes-benz/valhalla
that referenced
this pull request
Nov 22, 2023
## Summary Updated our codebase to latest Valhalla master without any conflicts apart from Dockerfile. ## Github Issues: - Enhance valhalla_build_elevation with LZ4 recompression support (Issue 3607) - Few admin fixes & suggestions (Issue 3619) - Update CHANGELOG.md (Issue 3620) - support nulls in config-based speed assignment (Issue 3621) - Trim dijsktra expansion (Issue 3532) - Fix how max_matrix_distance is found (Issue 3635) - Cost matrix early abort (Issue 3611) - feat: add `pre-commit` hook for running the `format.sh` script (Issue 3637) - Remove duplicate constants (Issue 3642) - Forgot to adapt driving side and country access rules in [Issue 3619](valhalla#3619) (Issue 3652) - Add missing throw keyword (Issue 3651) - Add a couple of fixes to make it possible to natively build Valhalla on Apple Silicon (Issue 3653) - remove unused methods from midgard (Issue 3657) - Fix is_conditional_active(...) (Issue 3655) - upgrade pybind11 to v2.9.2 to remove cmake warning (Issue 3658) - Fix tiny bug in timedistance bss matrix (Issue 3659) - GTFS: Reading and Writing (Issue 3665) - mark edge segments with interpolated match points (Issue 3670) - FIX(android):Fix for build android. (Issue 3672) - BSS: refine edge type on which bss will be projected (Issue 3663) - Use a small snap to node distance when Projecting candidates (Issue 3677) - Remove duplicate implementations of `adjust_scores` (Issue 3673) - fix: Conan error when building Docker image. Issue 3685 (Issue 3689) - mac os ci updates (Issue 3693) - GTFS: Transcoding to GraphTiles (Issue 3669) - Use `starts_with()` instead of `substr(0, N)` getting and comparing to prefix (Issue 3702) - remove dockerfile-build and install deps directly (Issue 3690) - add ferry support to truck model (Issue 3710) - fix docker setup (Issue 3714) - no expressions to default build args (Issue 3715) - format & lint python code (Issue 3713) - Fixed CostMatrix incorrect tile usage with oppedge (Issue 3719) - rename turkey admin to türkiye (Issue 3720) - Fix elevation serializing (Issue 3735) - Fix isochrones doc link (Issue 3739) - Allow country overrides for sidewalk (Issue 3711) - Precision checks (Issue 2652) - Fix PointXY::ClosestPoint to compile on GCC 12.2 (Issue 3737) - Wales and Scotland name change (Issue 3746) - Bump vcpkg (Issue 3754) - fix mac build (Issue 3757) - Pedestrian crossings are allowed for bikes. (Issue 3751) - Fix TimeDistanceMatrix results sequence (Issue 3738) - Bump RapidJSON to a more recent version (Issue 2475) - Set service road use in GetTripLegUse. (Issue 3763) - Disable Elevation Builder Test Until Issue 3740 is Complete (Issue 3769) - status endpoint should not answer queries if its shutting down (Issue 3785) - chore: Updates to clang-format 11.0.0 (Issue 3533) - Port trace_serializer to RapidJSON (Issue 3333) - port previous pr over to latest repo (Issue 3791) - Additional Fixed Speed Costing Option (Issue 3576) - CostMatrix fixes in SetSources and ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one french territory changed its name. also one suggestion, but I'm not so sure about it myself.