Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how max_matrix_distance is found #3635

Merged
merged 2 commits into from
May 18, 2022
Merged

Fix how max_matrix_distance is found #3635

merged 2 commits into from
May 18, 2022

Conversation

dnesbitt61
Copy link
Member

@dnesbitt61 dnesbitt61 commented May 17, 2022

Issue

#fixes #3634

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@kevinkreiser
Copy link
Member

we really have to refactor these run binaries to use actor or worker. every time we refactor or add stuff we always break these things...

kevinkreiser
kevinkreiser previously approved these changes May 17, 2022
@dnesbitt61
Copy link
Member Author

I thought about that for a minute or so, but don't have much time today. one thing this does though is compare CostMatrix to TimeDistanceMatrix which can be useful.

@kevinkreiser
Copy link
Member

yep, to do it right we need to build into the workers/actor a way to control a bit what it does underneath. totally understand not having enough time for it!

@dnesbitt61 dnesbitt61 merged commit bc21102 into master May 18, 2022
@dnesbitt61 dnesbitt61 deleted the run_matrix_fix branch May 18, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

valhalla_run_matrix fails
2 participants