Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate constants #3642

Merged
merged 3 commits into from
May 26, 2022
Merged

Remove duplicate constants #3642

merged 3 commits into from
May 26, 2022

Conversation

dnesbitt61
Copy link
Member

@dnesbitt61 dnesbitt61 commented May 26, 2022 •
edited
Loading

Issue

Fixes #3641.

Replaces:
RAD_PER_DEG --> kRadPerDegD
DEG_PER_RAD --> kDegPerRadD

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@dnesbitt61 dnesbitt61 merged commit 0c0fdcb into master May 26, 2022
@dnesbitt61 dnesbitt61 deleted the remove_dup_rad_constants branch May 26, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gknisely gknisely gknisely approved these changes

@kevinkreiser kevinkreiser Awaiting requested review from kevinkreiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RAD_PER_DEG and DEG_PER_RAD duplicate other constants
2 participants
@dnesbitt61 @gknisely