add distance limit in error message for 154 error code #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
Oct 3, 2022
| @@ -109,7 +109,7 @@ edges_in_rings(const google::protobuf::RepeatedPtrField<valhalla::Ring>& rings_p | |||
| rings_length += bg::perimeter(ring_bg, Haversine()); | |||
| } | |||
| if (rings_length > max_length) { | |||
| throw valhalla_exception_t(167, std::to_string(max_length)); | |||
There was a problem hiding this comment.
meter precision is enough IMO:)
nilsnolde
commented
Oct 3, 2022
| @@ -35,7 +35,8 @@ void check_distance(const google::protobuf::RepeatedPtrField<valhalla::Location> | |||
| } | |||
|
|
|||
| if (path_distance > matrix_max_distance) { | |||
| throw valhalla_exception_t{154}; | |||
| throw valhalla_exception_t{154, std::to_string(static_cast<size_t>(matrix_max_distance)) + | |||
There was a problem hiding this comment.
is there somewhere a function already that could replace std::to_string(static_cast<size_t>())? if not, would it make sense to add one to midgard.util.h or so?
nilsnolde
commented
Oct 3, 2022
| @@ -1073,7 +1073,7 @@ valhalla_exception_t::valhalla_exception_t(unsigned code, const std::string& ext | |||
| *this = code_itr->second; | |||
| } | |||
| if (!extra.empty()) | |||
| message += ":" + extra; | |||
| message += ": " + extra; | |||
There was a problem hiding this comment.
IMO it's nicer with a space after a colon
This was referenced Oct 3, 2022
Closed
kevinkreiser
previously approved these changes
Oct 23, 2022
|
can you re-approve @kevinkreiser ? |
kevinkreiser
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3722
@jackrea07 & @reillywynn , in case you want to have a look. Since it's really annoying for the web app to not display this info, I did it quickly myself.
@kevinkreiser, regarding your comment here: #3752 (comment)
In fact, most other errors are already returning the server-side limit. Maybe it'd make sense to return both, the actual limit and the passed value, since the passed value is often not readily comprehensible (e.g. crow distance etc). I went without for now, since most existing errors also simply state the server limit.