add matrix to gurka #3793
Merged
add matrix to gurka #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
force-pushed
the
nn-add-timeinfo-matrix
branch
from
418e2a5
to
2728c7b
Compare
nilsnolde
commented
Oct 13, 2022
Comment on lines
+65
to
+66
| std::string build_valhalla_request(const std::vector<std::string>& location_types, | ||
| const std::vector<std::vector<midgard::PointLL>>& waypoints, |
There was a problem hiding this comment.
these are now vectors of their previous types as to not have to overload this internal function
nilsnolde
commented
Oct 13, 2022
nilsnolde
commented
Oct 13, 2022
Comment on lines
+706
to
+714
| valhalla::Api do_action(const valhalla::Options::Action& action, | ||
| const map& map, | ||
| const std::vector<std::string>& sources, | ||
| const std::vector<std::string>& targets, | ||
| const std::string& costing, | ||
| const std::unordered_map<std::string, std::string>& options, | ||
| std::shared_ptr<valhalla::baldr::GraphReader> reader, | ||
| std::string* response, | ||
| std::string* request_json) { |
There was a problem hiding this comment.
another overload, unfortunately. I could've changed the signature of the do_action but it's public so I'd have to change every gurka test almost.
nilsnolde
commented
Oct 13, 2022
test/gurka/test_matrix.cc
Outdated
Comment on lines
7
to
16
| TEST(MatrixTest, MatrixSimple) { | ||
| constexpr double gridsize = 100; | ||
|
|
||
| // the grid below is 50 x 100 meters at 36 km/h, i.e. 10 m/s | ||
| const std::string ascii_map = R"( | ||
| A----B | ||
| | | | ||
| | | | ||
| C----D | ||
| )"; |
There was a problem hiding this comment.
Just a small dumb test to show it works. Unfortunately, there's nothing relevant inside the Api object that gets returned from do_action as we don't track stuff in PBF for matrix. We can only predict the distance but that could be fair enough with the right map
kevinkreiser
previously approved these changes
Oct 14, 2022
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
kevinkreiser
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3776
I think it'll be useful when dealing with adding time info to matrix.