Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle hexlifying strings with unsigned chars #3842

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

dillona
Copy link
Contributor

@dillona dillona commented Nov 24, 2022

Observed on aarch64-linux-gnu

Issue

Fixes #2923

Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kevinkreiser kevinkreiser merged commit d4c8c1a into valhalla:master Nov 24, 2022
@dillona dillona deleted the handle-unsigned-char branch November 25, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on non-x86*: "comparison is always true due to limited range of data type [-Werror=type-limits]"
2 participants