fix valhalla_build_extract #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tile path, not the full one
nilsnolde
commented
Dec 9, 2022
| @@ -143,15 +147,16 @@ def get_tiles_with_geojson(all_tile_paths: List[Path], geojson_dir: Path) -> Set | |||
| tile_paths_ = set() | |||
| geojson_polys = get_outer_rings(geojson_dir) | |||
| for tile_path in all_tile_paths: | |||
| tile_bbox = box(*get_tile_bbox(tile_path)) | |||
| tile_path_id = str(tile_path.relative_to(tiles_dir_)) | |||
There was a problem hiding this comment.
this is the important line: just forward the relative tile path to the get_tile_bbox function
kevinkreiser
previously approved these changes
Dec 15, 2022
|
Can you re-approve @kevinkreiser ? Thx. |
kevinkreiser
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should've done a full end to end test. Just wanted to use it and there was a bug, where it tried to derive the tile ID & level from the full path, rather than the relative tile path.