Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inline config to some more exe's #3873

Merged
merged 4 commits into from
Jan 3, 2023
Merged

add inline config to some more exe's #3873

merged 4 commits into from
Jan 3, 2023

Conversation

nilsnolde
Copy link
Member

For scriptability it's nicer to have inline config rather than a static JSON.

@kevinkreiser kevinkreiser merged commit 08c5527 into master Jan 3, 2023
@kevinkreiser kevinkreiser deleted the nn-inline-config branch January 3, 2023 13:33
@Blagodarenko
Copy link

Hi! return of function ParseArguments() is always false (or EXIT_FAILURE).
@nilsnolde , seems you skip return true after https://github.com/valhalla/valhalla/blob/master/src/mjolnir/valhalla_ways_to_edges.cc#L73 or need to change return false to true

@nilsnolde
Copy link
Member Author

Ooops 😅 It looks like you're right. I'm not using that executable since a longer time anymore. Do you want to PR?

@Blagodarenko
Copy link

Do you want to PR?
No, thanks 😄

and please check valhalla_build_admins, seems for "config" returns true, but for "inline-config" - always false (i didn't check it)

@nilsnolde
Copy link
Member Author

nilsnolde commented Apr 27, 2023

Haha ok, then you'll have to wait for someone to find the time to take care of this.

and please check valhalla_build_admins,

doesn't seem to be a problem. was too quick and overread inline-config. right, that looks a small problem as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants