Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Costing improvements #3912

Open
nilsnolde opened this issue Jan 16, 2023 · 0 comments
Open

Costing improvements #3912

nilsnolde opened this issue Jan 16, 2023 · 0 comments

Comments

@nilsnolde
Copy link
Member

nilsnolde commented Jan 16, 2023

In #3896 I suggested another way of weighting costing factors. We discussed it in more detail last week and found:

  1. Re-ordering the factors could make sense
  2. Trying to only penalize instead of doing both penalizing & favoring with use_* factors
  3. There was smth else but I forgot.. @kevinkreiser @dnesbitt61?

In any case, 1. is not much work by itself, while 2. is quite intense. Both would need to go through a LOT of RAD testing and since they're pretty independent things but very likely causing big changes in responses, we should do one-by-one and separate RAD testing.

It was also concluded that, while strictly speaking we wouldn't have to bump the major version for any of these, it's probably a good idea to phase it in over a period of time, e.g. by providing separate copy/paste/edit costing models or a new next_gen boolean flag in the request, for users to turn on & trial the new logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant